Yimaru/Yimaru-BackEnd
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: allow audio-only dynamic questions without text stimulus

Browse Source 
DYNAMIC question create no longer requires QUESTION_TEXT, INSTRUCTION, or TEXT_PASSAGE in dynamic_payload; validation follows the type definition only.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Yared Yemane 2026-06-08 02:20:11 -07:00
parent 685e1d104f
commit 55df6b8b0b
2 changed files with 26 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/domain/question_type_builder.go
View File

@ -573,13 +573,14 @@ func ValidateQuestionTextNotAllowedForDynamic(questionType string, explicit stri
return nil return nil
} }
if strings.TrimSpace(explicit) != "" { if strings.TrimSpace(explicit) != "" {
return fmt.Errorf("question_text is not used for DYNAMIC questions; set prompt text in dynamic_payload stimulus (QUESTION_TEXT, INSTRUCTION, or TEXT_PASSAGE)") return fmt.Errorf("question_text is not used for DYNAMIC questions; set prompt content in dynamic_payload stimulus per the selected type definition")
} }
return nil return nil
} }
// ResolveDynamicStoredQuestionText returns the questions.question_text column value for DYNAMIC rows // ResolveDynamicStoredQuestionText returns the questions.question_text column value for DYNAMIC rows
// (search/activity logs only; clients read prompt text from dynamic_payload). // (search/activity logs only; clients read prompt content from dynamic_payload).
// When the definition has no text stimulus kinds, an empty string is stored.
func ResolveDynamicStoredQuestionText(payload *DynamicQuestionPayload, existing string) (string, error) { func ResolveDynamicStoredQuestionText(payload *DynamicQuestionPayload, existing string) (string, error) {
if derived := StimulusTextFromPayload(payload); derived != "" { if derived := StimulusTextFromPayload(payload); derived != "" {
return derived, nil return derived, nil
@ -587,7 +588,7 @@ func ResolveDynamicStoredQuestionText(payload *DynamicQuestionPayload, existing
if strings.TrimSpace(existing) != "" { if strings.TrimSpace(existing) != "" {
return strings.TrimSpace(existing), nil return strings.TrimSpace(existing), nil
} }
return "", fmt.Errorf("dynamic_payload must include prompt text (QUESTION_TEXT, INSTRUCTION, or TEXT_PASSAGE)") return "", nil
} }
// QuestionTextJSONField returns question_text for API responses. Omitted (nil) for DYNAMIC questions. // QuestionTextJSONField returns question_text for API responses. Omitted (nil) for DYNAMIC questions.

26
internal/domain/question_type_builder_test.go
View File

@ -237,10 +237,28 @@ func TestResolveDynamicStoredQuestionText_fromINSTRUCTIONStimulus(t *testing.T)
} }
} }
func TestResolveDynamicStoredQuestionText_missingText(t *testing.T) { func TestResolveDynamicStoredQuestionText_noTextStimulusAllowed(t *testing.T) {
_, err := ResolveDynamicStoredQuestionText(&DynamicQuestionPayload{}, "") payload := &DynamicQuestionPayload{
if err == nil { Stimulus: []DynamicElementInstance{
t.Fatal("expected error when no prompt in payload") {ID: "audio_prompt_1", Kind: "AUDIO_PROMPT", Value: "https://cdn.example.com/audio/prompt.mp3"},
},
}
got, err := ResolveDynamicStoredQuestionText(payload, "")
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if got != "" {
t.Fatalf("expected empty stored text for audio-only payload, got %q", got)
}
}
func TestResolveDynamicStoredQuestionText_emptyPayload(t *testing.T) {
got, err := ResolveDynamicStoredQuestionText(&DynamicQuestionPayload{}, "")
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if got != "" {
t.Fatalf("expected empty stored text, got %q", got)
} }
} }