Yimaru/Yimaru-BackEnd
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Honor optional sort_order on course create under a program.

Browse Source 
Parses body sort_order, shifts sibling courses in-program, and inserts at the requested slot; omitting it keeps append-after-max behavior. Swagger/sqlc regenerated.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Yared Yemane 2026-05-19 02:54:17 -07:00
parent 1136a166f5
commit 37aef49e28
8 changed files with 77 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
db/query/lms_courses.sql
View File

@ -1,16 +1,17 @@
-- name: CreateCourse :one
INSERT INTO courses (program_id, name, description, thumbnail, sort_order)
SELECT
$1,
$2,
$3,
$4,
coalesce((
sqlc.arg('program_id'),
sqlc.arg('name'),
sqlc.arg('description'),
sqlc.arg('thumbnail'),
COALESCE(sqlc.narg('sort_order')::int,
COALESCE((
SELECT
max(c.sort_order)
FROM courses c
WHERE
c.program_id = $1), 0) + 1
c.program_id = sqlc.arg('program_id')), 0) + 1)
RETURNING
*;

7
docs/docs.go
View File

@ -4395,7 +4395,7 @@ const docTemplate = `{
}
},
"post": {
"description": "Create a course under a program",
"description": "Create a course under a program. Optional sort_order assigns position within that program (siblings shifted); omit to append after the current highest sort_order in the program.",
"consumes": [
"application/json"
],
@ -10364,6 +10364,11 @@ const docTemplate = `{
"name": {
"type": "string"
},
"sort_order": {
"description": "SortOrder within the program when set; omit to append after current max within program_id (uniqueness is per-program).",
"type": "integer",
"minimum": 0
},
"thumbnail": {
"type": "string"
}

7
docs/swagger.json
View File

@ -4387,7 +4387,7 @@
}
},
"post": {
"description": "Create a course under a program",
"description": "Create a course under a program. Optional sort_order assigns position within that program (siblings shifted); omit to append after the current highest sort_order in the program.",
"consumes": [
"application/json"
],
@ -10356,6 +10356,11 @@
"name": {
"type": "string"
},
"sort_order": {
"description": "SortOrder within the program when set; omit to append after current max within program_id (uniqueness is per-program).",
"type": "integer",
"minimum": 0
},
"thumbnail": {
"type": "string"
}

9
docs/swagger.yaml
View File

@ -338,6 +338,11 @@ definitions:
type: string
name:
type: string
sort_order:
description: SortOrder within the program when set; omit to append after current
max within program_id (uniqueness is per-program).
minimum: 0
type: integer
thumbnail:
type: string
required:
@ -5372,7 +5377,9 @@ paths:
post:
consumes:
- application/json
description: Create a course under a program
description: Create a course under a program. Optional sort_order assigns position
within that program (siblings shifted); omit to append after the current highest
sort_order in the program.
parameters:
- description: Program ID
in: path

7
gen/db/lms_courses.sql.go
View File

@ -18,12 +18,13 @@ SELECT
$2,
$3,
$4,
coalesce((
COALESCE($5::int,
COALESCE((
SELECT
max(c.sort_order)
FROM courses c
WHERE
c.program_id = $1), 0) + 1
c.program_id = $1), 0) + 1)
RETURNING
id, program_id, name, description, thumbnail, created_at, updated_at, sort_order
`
@ -33,6 +34,7 @@ type CreateCourseParams struct {
Name string `json:"name"`
Description pgtype.Text `json:"description"`
Thumbnail pgtype.Text `json:"thumbnail"`
SortOrder pgtype.Int4 `json:"sort_order"`
}
func (q *Queries) CreateCourse(ctx context.Context, arg CreateCourseParams) (Course, error) {
@ -41,6 +43,7 @@ func (q *Queries) CreateCourse(ctx context.Context, arg CreateCourseParams) (Cou
arg.Name,
arg.Description,
arg.Thumbnail,
arg.SortOrder,
)
var i Course
err := row.Scan(

2
internal/domain/course.go
View File

@ -36,6 +36,8 @@ type CreateCourseInput struct {
Name string `json:"name" validate:"required"`
Description *string `json:"description,omitempty"`
Thumbnail *string `json:"thumbnail,omitempty"`
// SortOrder within the program when set; omit to append after current max within program_id (uniqueness is per-program).
SortOrder *int `json:"sort_order,omitempty" validate:"omitempty,min=0"`
}
type UpdateCourseInput struct {

30
internal/repository/lms_courses.go
View File

@ -29,11 +29,41 @@ func courseToDomain(c dbgen.Course) domain.Course {
}
func (s *Store) CreateCourse(ctx context.Context, programID int64, input domain.CreateCourseInput) (domain.Course, error) {
if input.SortOrder != nil {
q, tx, err := s.BeginTx(ctx)
if err != nil {
return domain.Course{}, err
}
defer func() { _ = tx.Rollback(ctx) }()
target := int32(*input.SortOrder)
if _, err := tx.Exec(ctx,
`UPDATE courses SET sort_order = sort_order + 1 WHERE program_id = $1 AND sort_order >= $2`,
programID, target,
); err != nil {
return domain.Course{}, err
}
c, err := q.CreateCourse(ctx, dbgen.CreateCourseParams{
ProgramID: programID,
Name: input.Name,
Description: toPgText(input.Description),
Thumbnail: toPgText(input.Thumbnail),
SortOrder: pgtype.Int4{Int32: target, Valid: true},
})
if err != nil {
return domain.Course{}, err
}
if err := tx.Commit(ctx); err != nil {
return domain.Course{}, err
}
return courseToDomain(c), nil
}
c, err := s.queries.CreateCourse(ctx, dbgen.CreateCourseParams{
ProgramID: programID,
Name: input.Name,
Description: toPgText(input.Description),
Thumbnail: toPgText(input.Thumbnail),
SortOrder: pgtype.Int4{Valid: false},
})
if err != nil {
return domain.Course{}, err

2
internal/web_server/handlers/course_handler.go
View File

@ -13,7 +13,7 @@ import (
// CreateCourse godoc
// @Summary Create course
// @Description Create a course under a program
// @Description Create a course under a program. Optional sort_order assigns position within that program (siblings shifted); omit to append after the current highest sort_order in the program.
// @Tags courses
// @Accept json
// @Produce json