Yimaru/Yimaru-BackEnd
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: return updated lesson from UpdateSubModuleLesson after is_active false

Browse Source 
GetSubModuleLessonByID filters is_active=true, so refetch failed with 500
after soft-deactivating. Use RETURNING row from the update instead.

Made-with: Cursor
This commit is contained in:
Yared Yemane 2026-04-18 02:54:47 -07:00
parent ce1b827768
commit 24f1aca97a
1 changed files with 17 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
internal/web_server/handlers/hierarchy_handler.go
View File

@ -35,11 +35,11 @@ type createCourseReq struct {
} }
type updateCourseReq struct { type updateCourseReq struct {
Title *string `json:"title"` Title *string `json:"title"`
Description *string `json:"description"` Description *string `json:"description"`
Thumbnail *string `json:"thumbnail"` Thumbnail *string `json:"thumbnail"`
IntroVideoURL *string `json:"intro_video_url"` IntroVideoURL *string `json:"intro_video_url"`
IsActive *bool `json:"is_active"` IsActive *bool `json:"is_active"`
} }
type updateCourseThumbnailReq struct { type updateCourseThumbnailReq struct {
@ -1239,16 +1239,16 @@ func (h *Handler) UnifiedHierarchyByCourse(c *fiber.Ctx) error {
Message: "Course hierarchy retrieved successfully", Message: "Course hierarchy retrieved successfully",
Data: []map[string]interface{}{ Data: []map[string]interface{}{
{ {
"course_id": course.ID, "course_id": course.ID,
"course_title": course.Title, "course_title": course.Title,
"level_id": nil, "level_id": nil,
"cefr_level": nil, "cefr_level": nil,
"level_title": nil, "level_title": nil,
"level_description": nil, "level_description": nil,
"level_thumbnail": nil, "level_thumbnail": nil,
"module_id": nil, "module_id": nil,
"module_title": nil, "module_title": nil,
"module_icon_url": nil, "module_icon_url": nil,
"sub_module_id": nil, "sub_module_id": nil,
"sub_module_title": nil, "sub_module_title": nil,
"sub_module_description": nil, "sub_module_description": nil,
@ -1956,7 +1956,7 @@ func (h *Handler) UpdateSubModuleLesson(c *fiber.Ctx) error {
targetIsActive = *req.IsActive targetIsActive = *req.IsActive
} }
if _, err := h.analyticsDB.UpdateSubModuleLesson(c.Context(), dbgen.UpdateSubModuleLessonParams{ updatedLesson, err := h.analyticsDB.UpdateSubModuleLesson(c.Context(), dbgen.UpdateSubModuleLessonParams{
SubModuleID: targetSubModuleID, SubModuleID: targetSubModuleID,
Title: targetTitle, Title: targetTitle,
Description: targetDescription, Description: targetDescription,
@ -1968,17 +1968,10 @@ func (h *Handler) UpdateSubModuleLesson(c *fiber.Ctx) error {
DisplayOrder: targetDisplayOrder, DisplayOrder: targetDisplayOrder,
IsActive: targetIsActive, IsActive: targetIsActive,
ID: lessonID, ID: lessonID,
}); err != nil { })
return c.Status(fiber.StatusInternalServerError).JSON(domain.ErrorResponse{
Message: "Failed to update lesson",
Error: err.Error(),
})
}
updatedLesson, err := h.analyticsDB.GetSubModuleLessonByID(c.Context(), lessonID)
if err != nil { if err != nil {
return c.Status(fiber.StatusInternalServerError).JSON(domain.ErrorResponse{ return c.Status(fiber.StatusInternalServerError).JSON(domain.ErrorResponse{
Message: "Lesson updated but failed to fetch latest detail", Message: "Failed to update lesson",
Error: err.Error(), Error: err.Error(),
}) })
} }
@ -2989,4 +2982,3 @@ func (h *Handler) DeleteModuleCapstone(c *fiber.Ctx) error {
} }
return c.JSON(domain.Response{Message: "Module capstone deleted"}) return c.JSON(domain.Response{Message: "Module capstone deleted"})
} }